Skip to content

Commit

Permalink
Merge pull request #54 from davidcarslaw/fix/ggmap
Browse files Browse the repository at this point in the history
test: remove tests
  • Loading branch information
jack-davison committed Nov 2, 2023
2 parents 9cd2cd4 + 87cc563 commit b4385ef
Show file tree
Hide file tree
Showing 16 changed files with 4 additions and 311 deletions.
50 changes: 0 additions & 50 deletions .github/workflows/test-coverage.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,7 @@ Imports:
Suggests:
httr,
jsonlite,
covr,
testthat (>= 3.0.0),
worldmet
Config/testthat/edition: 3
Encoding: UTF-8
Language: en-GB
LazyData: true
Expand Down
14 changes: 1 addition & 13 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ knitr::opts_chunk$set(
<!-- badges: start -->
[![R-CMD-check](https://github.com/davidcarslaw/openairmaps/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/davidcarslaw/openairmaps/actions/workflows/R-CMD-check.yaml)
[![CRAN status](https://www.r-pkg.org/badges/version/openairmaps)](https://CRAN.R-project.org/package=openairmaps)
[![Codecov test coverage](https://codecov.io/gh/davidcarslaw/openairmaps/branch/master/graph/badge.svg)](https://app.codecov.io/gh/davidcarslaw/openairmaps?branch=master)
<!-- badges: end -->

The main goal of `{openairmaps}` is to combine the robust analytical methods found in [openair](https://davidcarslaw.github.io/openair/) with the highly capable `{leaflet}` package. `{openairmaps}` is thoroughly documented in the [openair book](https://bookdown.org/david_carslaw/openair/sections/maps/maps-overview.html).
Expand Down Expand Up @@ -70,15 +69,4 @@ knitr::include_graphics("man/figures/README-examplemap.png")
While an interactive map is preferred for exploratory directional analysis, it is limited to the HTML format. Some applications (for example, academic journals) demand "static" formats like .docx and .pdf. For this reason, "static" versions of `{openairmaps}` polar marker functions have been provided which are written in `{ggplot2}`. A benefit of being written in `{ggplot2}` is that additional layers can be added (e.g., `geom_label()` could be used to label sites) and limited further customisation is available using `theme()` and `guides()`.
```{r static, fig.width = 9, fig.height = 5, message = FALSE, warning = FALSE, fig.cap="A demonstration of `polarMapStatic()`.", fig.alt="A natively static polar plot map. It shows an OpenStreetMap map layer, overlaid with bivariate polar plots. Polar plots are visualisations on polar coordinates with wind direction on the spoke axes, wind speed on the radial axes, and a smooth surface showing pollutant concentrations. The map is split into two, with one panel for daylight observations and the other for nighttime."}
polar_data %>%
openair::cutData("daylight") %>%
polarMapStatic(
pollutant = "no2",
limits = c(0, 180),
facet = "daylight",
alpha = .75,
d.icon = 100,
d.fig = 2.5
)
```
Static maps require users to provide a [ggmap](https://github.com/dkahle/ggmap) tileset, which at the time of writing requires an API key for either Google or Stadia Maps.
26 changes: 3 additions & 23 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
[![R-CMD-check](https://github.com/davidcarslaw/openairmaps/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/davidcarslaw/openairmaps/actions/workflows/R-CMD-check.yaml)
[![CRAN
status](https://www.r-pkg.org/badges/version/openairmaps)](https://CRAN.R-project.org/package=openairmaps)
[![Codecov test
coverage](https://codecov.io/gh/davidcarslaw/openairmaps/branch/master/graph/badge.svg)](https://app.codecov.io/gh/davidcarslaw/openairmaps?branch=master)
<!-- badges: end -->

The main goal of `{openairmaps}` is to combine the robust analytical
Expand Down Expand Up @@ -82,24 +80,6 @@ of being written in `{ggplot2}` is that additional layers can be added
(e.g., `geom_label()` could be used to label sites) and limited further
customisation is available using `theme()` and `guides()`.

``` r
polar_data %>%
openair::cutData("daylight") %>%
polarMapStatic(
pollutant = "no2",
limits = c(0, 180),
facet = "daylight",
alpha = .75,
d.icon = 100,
d.fig = 2.5
)
```

<div class="figure">

<img src="man/figures/README-static-1.png" alt="A natively static polar plot map. It shows an OpenStreetMap map layer, overlaid with bivariate polar plots. Polar plots are visualisations on polar coordinates with wind direction on the spoke axes, wind speed on the radial axes, and a smooth surface showing pollutant concentrations. The map is split into two, with one panel for daylight observations and the other for nighttime." width="100%" />
<p class="caption">
A demonstration of `polarMapStatic()`.
</p>

</div>
Static maps require users to provide a
[ggmap](https://github.com/dkahle/ggmap) tileset, which at the time of
writing requires an API key for either Google or Stadia Maps.
12 changes: 0 additions & 12 deletions tests/testthat.R

This file was deleted.

35 changes: 0 additions & 35 deletions tests/testthat/test-addPolarMarkers.R

This file was deleted.

5 changes: 0 additions & 5 deletions tests/testthat/test-addTrajPaths.R

This file was deleted.

29 changes: 0 additions & 29 deletions tests/testthat/test-networkMap.R

This file was deleted.

17 changes: 0 additions & 17 deletions tests/testthat/test-polar_annulusMap.R

This file was deleted.

17 changes: 0 additions & 17 deletions tests/testthat/test-polar_freqMap.R

This file was deleted.

22 changes: 0 additions & 22 deletions tests/testthat/test-polar_percentileMap.R

This file was deleted.

17 changes: 0 additions & 17 deletions tests/testthat/test-polar_polarMap.R

This file was deleted.

17 changes: 0 additions & 17 deletions tests/testthat/test-polar_pollroseMap.R

This file was deleted.

12 changes: 0 additions & 12 deletions tests/testthat/test-polar_windroseMap.R

This file was deleted.

21 changes: 0 additions & 21 deletions tests/testthat/test-traj_trajLevelMap.R

This file was deleted.

18 changes: 0 additions & 18 deletions tests/testthat/test-traj_trajMap.R

This file was deleted.

0 comments on commit b4385ef

Please sign in to comment.