Kaminari 1.0 last_page? behavior fix #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidcelis any idea when you can review this? |
|
@sandrew Sorry about the wait, I've been out sick for a little while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New kaminari 1.0's
last_page?method behavior is changed: now it returns false if current page is bigger then total pages.This breaks our API:
Linkheader withnextandlasturls appears even on the empty collection (becausecurrent_pageis always 1 andtotal_pagesis always 0).This pull-request adds work-around keeping in mind that WillPaginate does not have
#out_of_range?method.