Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My own disliked items in my recommended set #73

Closed
julianfox opened this issue Apr 30, 2013 · 5 comments
Closed

My own disliked items in my recommended set #73

julianfox opened this issue Apr 30, 2013 · 5 comments

Comments

@julianfox
Copy link

Hi David,

I found my own disliked items in my recommended set if my similar users like this items, is it normal ?

If yes, it would be a good improvement to delete disliked items by user before to add score in recommended set.

@davidcelis
Copy link
Owner

No, items that have been rated by a user should not appear in that user's set of recommendations. Recommendable implements hooks that remove an item from the set of recommendations once it has been rated, and the logic to calculate recommendations also ignores items that have already been rated. Can you please detail your set of actions? This isn't something I've ever been able to make happen.

@hderms
Copy link

hderms commented Apr 30, 2013

Why not just report the difference between the recommended items and the
users disliked items?

On Tue, Apr 30, 2013 at 4:27 PM, David Celis notifications@github.comwrote:

No, items that have been rated by a user should not appear in that user's
set of recommendations. Recommendable implements hooks that remove an item
from the set of recommendations once it has been rated, and the logic to
calculate recommendations also ignores items that have already been rated.
Can you please detail your set of actions? This isn't something I've ever
been able to make happen.


Reply to this email directly or view it on GitHubhttps://github.com//issues/73#issuecomment-17255359
.

@davidcelis
Copy link
Owner

@hderms Perhaps there's a misunderstanding, but his problem seems to be that a he disliked an item but later found it in his recommendations. Recommendable has hooks that should have removed it from the recommendations, but perhaps they didn't get run for some reason.

@julianfox
Copy link
Author

Ok, no sorry, after many tests, everything seems ok, error was due to an external code. thanks

@davidcelis
Copy link
Owner

Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants