Check className has a truthy value before trying anything else

[msallent]

We recently had an issue on one of our projects where IE11 would crash and go entirely blank. After some hours of debugging, we found the culprit, which was setting selectedClass as an empty string.

This PR intends to fix that by first checking if className has a truthy value before moving forward.

To give a little bit more of context on the issue and how it happened:

We have a useSlider hook that wraps useEmblaCarousel and adds some extra functionality, and seeing as we were not using the selectedClass, we initialized Embla's hook like this:

const [setEmblaSliderRef, emblaAPI] = useEmblaCarousel({
  selectedClass: "",
  ...options,
});

Unfortunately the project's repo is private and we can't share any of our staging environments for you to test this. I tried forking the CodeSandbox specified in the CONTRIBUTIONS document but it threw out a 404. Anyways, this shouldn't be too hard to replicate for you to test.

If you need any additional information, please let me know. Thank you!

[davidjerleke]

Hi Matias (@msallent),

Thank you for taking time to create this PR. So if I understand you correctly:

• The page crashed on IE11 because of the reason you mention.
• You opted out of selectedClass because you don’t need to use it in your project?

Is this a show stopper for your project?

Thanks again for this PR. I will merge it and release it as soon as possible. Also, thanks a lot for pointing out the broken link in the contribution document. I will update it soon.

Best,
David

[msallent]

Hey @davidcetinkaya!

Not a show stopper, thankfully. We just decided to remove setting selectedClass as an empty string and move on, but I first wanted to take five minutes and open a PR as we've been using your package with no issues at all.

Thank you for the awesome carousel!

[davidjerleke]

Thanks again Matias (@msallent).

I've merged your PR now so welcome to the contributors club 🙂. Release v4.0.5 comes with your fix. Please update the embla-carousel package to the latest version.

Have a great day!
David