Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_errors argument to shutil.rmtree() #20

Closed
wants to merge 6 commits into from

Conversation

michaeltryby
Copy link

Close #19

When running nrtest on Windows an error is generated because rtol and atol command line arguments aren't being converted from string to float. This can be fixed by specifying the argument type when adding the arguments in the nrtest script.
Syncing to upstream remote
Add ignore_errors argument
@coveralls
Copy link

coveralls commented Jul 18, 2019

Coverage Status

Coverage remained the same at 28.297% when pulling 6f277ff on michaeltryby:master into b244020 on davidchall:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.297% when pulling d8cd4d2 on michaeltryby:master into b244020 on davidchall:master.

@davidchall
Copy link
Owner

Hi @michaeltryby,
I looked into this issue, and unfortunately setting ignore_errors=True has the effect of simply not reporting the error message. The directory will not be deleted.

I'm going to open a new PR with a more robust solution.

@davidchall davidchall closed this Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shutil.rmtree() in execute.py throws a directory is not empty error
3 participants