Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make behaviour of convhulln() and delaunayn() consistent #29

Open
davidcsterratt opened this issue Feb 7, 2019 · 1 comment
Open

Make behaviour of convhulln() and delaunayn() consistent #29

davidcsterratt opened this issue Feb 7, 2019 · 1 comment
Assignees
@davidcsterratt
Milestone
0.4.6

Comments

@davidcsterratt
Copy link
Owner

davidcsterratt commented Feb 7, 2019 •
edited
Loading

In the current version of the package, the behaviour of convhulln() and delaunayn() differ:

  • convhulln(): If the Qhull options n or FA are included in the options string, returns a list. Otherwise return a matrix.

  • delaunayn(): If the full option is supplied return the areas and neighbours of each simplex.

It would be good to normalise the behaviour by removing the full option from delaunayn and only outputting a list when options such as Fa and Fn are specified. The only call to delaunayn with the full option is delaunayn(as.matrix(data), options="Fa Fn", full=T) in the restlos package.

Thus the proposal is:

  • Make delaunayn respond to Fa and Fn options, outputting areas and neighbours
  • Deprecate full, producing a WARNING
davidcsterratt added a commit that referenced this issue Feb 8, 2019
@davidcsterratt
Issue #29: Make behaviour of convhulln() and delaunayn() consistent
3c0149b 
Make delaunayn respond to Fa and Fn options, outputting areas and neighbours.
@davidcsterratt
Copy link
Owner Author

In 0.4.0 there is no message or warning; messages and then warnings will be added in future versions of geometry.

davidcsterratt added a commit that referenced this issue Feb 17, 2019
@davidcsterratt
Issue #29: Make delaunayn() and convhulln() consistent
6e5f8d4 
There was a problem with replacing full by suggesting using "FA Fn"
for options in delaunayn, since this got rid of the default options,
which could lead to unrpedictable results. The new solution is to make
a new output.options argument to delaunayn() and convhulln().  This
takes Qhull options, but can also be set to TRUE to specify all
possible output options.
davidcsterratt added a commit that referenced this issue Feb 17, 2019
@davidcsterratt
Issue #29: Make behavior of convhulln() and delaunayn() consistent
54bc5e6 
These functions now always return a qhull attribute called convhulln
or delaunayn. Before the names were convhull and delaynayTriangulation.
@davidcsterratt davidcsterratt self-assigned this Feb 18, 2019
@davidcsterratt davidcsterratt modified the milestone: 0.4.3 Jul 12, 2019
@davidcsterratt davidcsterratt modified the milestones: 0.4.3, 0.4.4 Aug 21, 2019
davidcsterratt added a commit that referenced this issue Feb 1, 2023
@davidcsterratt
Issue #29: Enable deprecated warning for delaunayn full option
0a9a708
davidcsterratt added a commit that referenced this issue Feb 1, 2023
@davidcsterratt
Issue #29: plot.delaunayn() function
484a4cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcsterratt davidcsterratt

Labels
None yet
Projects
None yet
Milestone
0.4.6
Development

No branches or pull requests
1 participant
@davidcsterratt