Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use proper favicons #122

Merged
merged 8 commits into from Mar 13, 2019
Merged

[Enhancement] Use proper favicons #122

merged 8 commits into from Mar 13, 2019

Conversation

daviddarnes
Copy link
Owner

Previously, the only form of site icons / logos was the logo and the avatarurl keys in the config. The avatarurl was taking advantage of the image resizing provided by Gravatar. Collectively this all came with multiple issues:

  • You can't use an SVG image in the app manifest, you need raster images
  • You may not be using Gravatar to represent your website
  • You couldn't control what favicons you have on the site
  • You couldn't bundle the icons into the project easily

These proposed changes allow for More fine tuned control of favicons and manifest icon sizes. It also fixes the PWA error when using an SVG for a manifest icon. For legacy users avatarurl will still be available but only for the shortcut icon meta item.

@daviddarnes daviddarnes merged commit f6cb8cf into master Mar 13, 2019
@daviddarnes daviddarnes deleted the use-proper-favicons branch March 13, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant