Update jekyll and bundle versions in gemspec #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to use this theme as a gem on a fresh jekyll install results in the following error:
```
Bundler could not find compatible versions for gem "jekyll":
In Gemfile:
jekyll (~> 4.0.0)
garth-jekyll-theme (~> 1.0.4) was resolved to 1.0.4, which depends on
jekyll (~> 3.6)
```
This PR fixes the issue by updating the jekyll depencency.
|
Hey @jordigarcl! Thanks for using my theme and for providing a fix. Nice spot with the jekyll version issue, I don't suppose you can try out setting the jekyll version to the following: This should widen the scope of compatibility rather than bumping it up |
|
@daviddarnes I've tried your suggestion and it seems to work fine. I've done the same for the bundler dependency, which was also giving me issues with my local PD: This is a very nice theme! |
|
Awesome stuff, thanks for the fix and for the kind words! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use this theme as a gem on a fresh jekyll install results in the following error:
This PR fixes the issue by updating the jekyll depencency.