Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: links not being shared on Firefox mobile #3

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix: links not being shared on Firefox mobile #3

merged 1 commit into from
Apr 18, 2024

Conversation

rg-wood
Copy link
Contributor

@rg-wood rg-wood commented Apr 18, 2024 •
edited
Loading

Links not being shared from Firefox Mobile on Android.

Expected result (with this fix):

Expected Screenshot of share in Gmail

Actual result:

Actual Screenshot of share in Gmail

@daviddarnes
Copy link
Owner

Oh good spot and fix, does this work in all browsers? Surprised url isn't more clearly documented on MDN:
https://developer.mozilla.org/en-US/docs/Web/API/Web_Share_API#api.navigator.share

@daviddarnes daviddarnes added the bug Something isn't working label Apr 18, 2024
@rg-wood
Copy link
Contributor Author

rg-wood commented Apr 18, 2024

I tested it on Chrome, but I don't have an iPhone to test.

@rg-wood
Copy link
Contributor Author

rg-wood commented Apr 18, 2024

It works in Safari.

@daviddarnes daviddarnes merged commit d733674 into daviddarnes:main Apr 18, 2024
@daviddarnes
Copy link
Owner

Thanks for this fix @rg-wood! Will bump the version and do a new release 🎉

@rg-wood rg-wood deleted the fix-links-firefox-share branch April 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rg-wood @daviddarnes