Use re.fullmatch when available #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddrysdale
approved these changes
Dec 2, 2023
python/phonenumbers/re_util.py
Outdated
| return m | ||
|
|
||
|
|
||
| if __name__ == "__main__": # pragma no cover |
There was a problem hiding this comment.
nit: is there a reason to change quote style and add blank lines?
There was a problem hiding this comment.
nope, autoformatting - fixed now, sorry.
Tasssadar
force-pushed
the
fullmatch_fast
branch
from
c6c7813
to
e1f9632
Compare
daviddrysdale
approved these changes
Dec 5, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's
rehasfullmatchmethod built-in since 3.4, and it is much faster than re-compiling the patterns all the time. The speed-up is visible even when running tests, they are 1s faster with this.Also removing the
flagsparameter, which was unused and broken.