Skip to content

Commit

Permalink
Adds some return type to functions
Browse files Browse the repository at this point in the history
  • Loading branch information
davide-casiraghi committed Mar 18, 2020
1 parent 6c24440 commit 9f17bca
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/Http/Controllers/ContinentController.php
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public function destroy(Continent $continent)
* @param \Illuminate\Http\Request $request
* @return int $ret
*/
public static function updateContinentsDropdown(Request $request)
public static function updateContinentsDropdown(Request $request): int
{
$selectedCountry = Country::find($request->get('country_id'));
$ret = $selectedCountry->continent_id;
Expand Down
2 changes: 1 addition & 1 deletion src/Http/Controllers/Controller.php
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function getLoggedAuthorId()
* @param int $thumbWidth
* @return void
*/
public static function uploadImageOnServer($imageFile, string $imageName, string $imageSubdir, int $imageWidth, int $thumbWidth)
public static function uploadImageOnServer($imageFile, string $imageName, string $imageSubdir, int $imageWidth, int $thumbWidth): void
{

// Create dir if not exist (in /storage/app/public/images/..)
Expand Down
2 changes: 1 addition & 1 deletion src/Http/Controllers/EventCategoryController.php
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function destroy(EventCategory $eventCategory)
* @param \DavideCasiraghi\LaravelEventsCalendar\Models\EventCategory $eventCategory
* @return void
*/
public function saveOnDb(Request $request, EventCategory $eventCategory)
public function saveOnDb(Request $request, EventCategory $eventCategory): void
{
$eventCategory->name = $request->get('name');
$eventCategory->slug = Str::slug($eventCategory->name, '-');
Expand Down
4 changes: 2 additions & 2 deletions src/Http/Controllers/EventController.php
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ public function destroy(Event $event)
* @param int $eventId
* @return void
*/
public function saveEventRepetitions(Request $request, int $eventId)
public function saveEventRepetitions(Request $request, int $eventId): void
{
EventRepetition::deletePreviousRepetitions($eventId);

Expand Down Expand Up @@ -592,7 +592,7 @@ public function calculateMonthlySelectOptions(Request $request)
* @param \DavideCasiraghi\LaravelEventsCalendar\Models\Event $event
* @return void
*/
public function saveOnDb(Request $request, Event $event)
public function saveOnDb(Request $request, Event $event): void
{
//$countries = Country::getCountries();
$teachers = Teacher::pluck('name', 'id');
Expand Down
2 changes: 1 addition & 1 deletion src/Http/Controllers/OrganizerController.php
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public function destroy(Organizer $organizer)
* @param \DavideCasiraghi\LaravelEventsCalendar\Models\Organizer $organizer
* @return int
*/
public function saveOnDb(Request $request, Organizer $organizer)
public function saveOnDb(Request $request, Organizer $organizer): int
{
$organizer->name = $request->get('name');
$organizer->description = clean($request->get('description'));
Expand Down
2 changes: 1 addition & 1 deletion src/Http/Controllers/RegionController.php
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ public function destroy(Region $region)
* @param \DavideCasiraghi\LaravelEventsCalendar\Models\Region $region
* @return void
*/
public function saveOnDb(Request $request, Region $region)
public function saveOnDb(Request $request, Region $region): void
{
$region->name = $request->get('name');
$region->country_id = $request->get('country_id');
Expand Down

0 comments on commit 9f17bca

Please sign in to comment.