Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FastScroller #34

Closed
7 tasks done
davideas opened this issue Jan 31, 2016 · 10 comments
Closed
7 tasks done

New FastScroller #34

davideas opened this issue Jan 31, 2016 · 10 comments
Milestone

Comments

@davideas
Copy link
Owner

davideas commented Jan 31, 2016

New FastScroller:

  • Autohide.
  • Improving configuration.
  • Bubble can be enabled/disabled and position tuned on Y axis too.
  • FastScrollerDelegate and Interface, to be used standalone outside of FlexibleAdapter (still inside the package).
  • IgnoreTouchesOutsideHandle
  • Extends / Separate the copyright for FastScroller in the readme.
  • Customizable minimum scroll amount to show the FastScroller.

Other sources:

@davideas
Copy link
Owner Author

davideas commented May 1, 2016

The existing FastScroller has been improved from v5.0.0-b6.

@davideas davideas modified the milestones: 5.0.0, 5.0.0-rc2 Nov 22, 2016
@arpinca
Copy link
Contributor

arpinca commented Mar 6, 2017

hello! the FastScroller is awesome :D i plan to use it on my application but i need to customize it a bit more i.e. set the handle color, bubble position, autohide, etc. preferably via custom attributes. if you're interested, i can try to make a PR

@davideas
Copy link
Owner Author

davideas commented Mar 6, 2017

Hello @arpinca, thank you for your message, indeed FastScroller needs more customization.
Actually shapes and colors can be customized by creating a layout with same id the FastScroller is setting, but you can do better.
Autohide is something really nice, i will appreciate your effort. You can indeed create a PR.

@davideas
Copy link
Owner Author

@arpinca, I've successfully imported your improvements in the new branch.
My next step is to improve as well the configuration. My idea is to pass only the FastScroller object already configured in advance, like the layout manager. So I will need to clean a little bit some settings.

@arpinca
Copy link
Contributor

arpinca commented Mar 23, 2017

Hi @davideas, thanks.

My idea is to pass only the FastScroller object already configured in advance, like the layout manager.

Cool. This would make using FastScroller easier, especially when not using the adapters here. In my case, there's already an adapter class which I can't easily change, and I only need the FastScroller, so ...

Btw, I also have other improvements in mind, like

  • extracting the animation to another class
  • ignore the accentColor, and simply rely on the color specified in the drawable and layout files (or better yet, add this as custom attribute)
  • make some methods protected so that this class can be extended i.e. override setBubbleAndHandlePosition to add a gap between the bubble and the handle
  • add a delegate

what do you think?

@davideas
Copy link
Owner Author

@arpinca, check what I've committed yesterday in customizable_fastscroller branch: Color as attribute is done by me.

So you can start from that commit.

  • Ok, for the gap, but you can add a new public method, because setBubbleAndHandlePosition is only for Y coordinate (scrolling).
  • Animation as different class, what do you mean?
  • Delegate for which operations?
  • Do you think we can programmatically generate the Drawables instead of using resources?

@inorichi
Copy link

Would it be possible to make the bubble optional? I have a particular use case with a lot of elements in no particular order, and I think showing the index in the bubble is more confusing than helpful, but I still want to provide a quick way to scroll the entire list.

@davideas
Copy link
Owner Author

@arpinca, indeed it can be optional.

@arpinca
Copy link
Contributor

arpinca commented Mar 27, 2017

yeah, i agree that the bubble should be optional.

Do you think we can programmatically generate the Drawables instead of using resources?

Hmm I prefer using resources so that I can use whatever shape i want, or update the layout by simply editing the xml. i.e. if I want the handle to have curved edges, or if i want to add another textview in the bubble, or change the horizontal gap between the bubble and the handle

So you can start from that commit.

OK! I'll send a PR soon :D
For the gap, I mean vertical gap. e.g. when the user scrolls to the very end, i want the bubble to reach the end also.

@tprochazka
Copy link

I tested current fast stroller in the RC1 and it is strange that it stay on one place for quite long time during I scrolling before it start moving. It happen also in the demo app. I was created bug report, but if new FastScroll is on the way it probably doesn't make sense. I also mist auto hide, but it will be in new one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants