Position must be increased by value returned from "expand" method.

[AlexandreGorobets]

FlexibleAdapter/flexible-adapter/src/main/java/eu/davidea/flexibleadapter/FlexibleAdapter.java

Line 435 in 131ac64

position++; //+1 Check also subItems with expanded = true

Currently in case of multilevel expanded items, they will be added more then one time to the mItems list.

[davideas]

Already worked on it. No duplication.
It is similar to a recursive function, having a sub-item that is expandable will expand also its children. If not expandable the if isExpanded(item) returns false, and it goes to the next position without appending items. So no duplication.

[AlexandreGorobets]

Examlple:
level0 1
level1 1_1
level2 1_1_1
level0 2

All items 1, 1_1 and 1_1_1 marked as Expanded on adapter fill
Then I call method expandItemsAtStartUp
At first iteration ("position" == 0) after processing item 1 you will add all expanded items (1_1 and 1_1_1) to mItems list.
On next loop iteration ("position" == 1) item 1_1 will be processed and item 1_1_1 will be added to mItems again.
And this is error. "position" must be increased on size on new item that was added to mItems, because we already processed all child items recursively.

[davideas]

@AlexandreGorobets, I will check again, it might be that after I added the recursive function I didn't modify the expandItemsAtStartUp() function.

[davideas]

@AlexandreGorobets, thanks to have insisted because the function was modified initially to expand all subItems. Then I added the recursive expand function without modifying the start up function.
I will try to add also a UnitTest on it now.

Time is always limited for this open library, unfortunately.

[AlexandreGorobets]

Nice job!)
Thank you for fast response!