fix: always providing a readable body #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebianchi
requested changes
Jul 4, 2020
| } | ||
|
|
||
| defer func() { | ||
| resp.Body.Close() | ||
| resp.Body = ioutil.NopCloser(bytes.NewBuffer(bodyBytes)) |
There was a problem hiding this comment.
In this way we copy 2 times the response body, but the common library use case is to access to the json response body and unmarshal it in a given structure. So this change is an unnecessary copy of a possibly large body.
What's your use case to reuse the response body?
What do you think about set this behaviour under an option flag in client creation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.