Skip to content

Commit

Permalink
Fix compatibility issues with JEST and similar frameworks.
Browse files Browse the repository at this point in the history
Cause:
Since @types\jest adds two additional properties to the NodeRequire function (requireActual, and requireMock),
this causes compatibility issues when using live-plugin-manager in a project that also uses jest.
Since typescript resolves files ending in .ts before files ending in .d.ts, the original src files
are getting compiled each time a consuming project runs tsc. This behavior is undesirable and can
cause compatibility issues since the modified types no longer match.
  • Loading branch information
Fabrice Ketchakeu committed Jul 20, 2020
1 parent 1fa4387 commit dc91492
Show file tree
Hide file tree
Showing 53 changed files with 45 additions and 164 deletions.
File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions dist/index.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions dist/src/GithubRegistryClient.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions dist/src/NpmRegistryClient.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion src/PackageInfo.js.map → dist/src/PackageInfo.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion src/PluginInfo.js.map → dist/src/PluginInfo.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/PluginManager.d.ts → dist/src/PluginManager.d.ts
@@ -1,5 +1,4 @@
/// <reference types="node" />
/// <reference types="mocha" />
import { NpmRegistryConfig } from "./NpmRegistryClient";
import { IPluginInfo } from "./PluginInfo";
import { GithubAuth } from "./GithubRegistryClient";
Expand Down
2 changes: 1 addition & 1 deletion src/PluginManager.js → dist/src/PluginManager.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dist/src/PluginManager.js.map

Large diffs are not rendered by default.

File renamed without changes.
2 changes: 1 addition & 1 deletion src/PluginVm.js → dist/src/PluginVm.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dist/src/PluginVm.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.

0 comments on commit dc91492

Please sign in to comment.