Mouse edge distance fix #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve issues using distance or bottom and right.
|
@davidfig Anything I need to do in order to get this looked over? Thanks! |
Totally need this feature in <3 |
|
👀 🙏 👀 |
|
@davidfig I would also love to see this in! I will build a workaround now (reinitialize the plugin on resize with overwriting worldScreen* in viewport) |
|
@AjayKoenigArcurve @kurtwaldowski-echelon : There is a nice workaround (worldScreenX = screenX * scale): // workaround until https://github.com/davidfig/pixi-viewport/pull/373 is merged
const oldScale = {x: viewport.scale.x, y: viewport.scale.y}
viewport.scale = {x: 1, y: 1}
viewport.plugins.get('mouse-edges')?.resize()
viewport.scale = oldScale |
|
@ribx Thanks for the workaround, I forked but may run with this instead for now! |
Confirmed it works on my end as well, thanks for this for the time being. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong variable was used, causing strange behavior when using MouseEdge with distance, for Right and Bottom.
This issue was mentioned here: #263
@davidfig