Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pixi.js to v6.5 #393

Merged
merged 4 commits into from
Aug 13, 2022
Merged

Upgrade pixi.js to v6.5 #393

merged 4 commits into from
Aug 13, 2022

Conversation

stevensnoeijen
Copy link
Contributor

The current build on pixi-viewport does not work with v6.5.0 because of changes in the pixi's DisplayObject.

Issue for this PR: #391

Changes:

Please merge #392 before merging this PR, this PR branch is extended from the electron fix.

@kurtwaldowski-echelon
Copy link
Contributor

The formatting changes make this merge seem much larger than it is

@stevensnoeijen
Copy link
Contributor Author

The formatting changes make this merge seem much larger than it is

Good point I'll check this tomorrow

@stevensnoeijen
Copy link
Contributor Author

The formatting changes make this merge seem much larger than it is

The formatting you mean is on the dist folder which is generated though yarn build and can be ignored, because I did not directly changed that. I did just run build this so that I can use these changes in the meanwhile.
When @davidfig creates a new release he probably run this again himself.

@kurtwaldowski-echelon
Copy link
Contributor

The formatting changes make this merge seem much larger than it is

The formatting you mean is on the dist folder which is generated though yarn build and can be ignored, because I did not directly changed that. I did just run build this so that I can use these changes in the meanwhile. When @davidfig creates a new release he probably run this again himself.

Derp good point! Thanks!

@stevensnoeijen
Copy link
Contributor Author

bump @davidfig

@davidfig davidfig merged commit db4d499 into davidfig:master Aug 13, 2022
@davidfig
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants