Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨✨✨ V5 ✨✨✨ #428

Merged
merged 24 commits into from
Feb 25, 2023
Merged

✨✨✨ V5 ✨✨✨ #428

merged 24 commits into from
Feb 25, 2023

Conversation

cuire
Copy link
Contributor

@cuire cuire commented Feb 7, 2023

Closes #426, #408 , #352, #378, #425.

Finally ready to merge PR.

That PR includes everything from #421. And adds more:

Installable via git now

While PR is no merged, you can use these to continue working on projects.

npm

npm i cuire/pixi-viewport#v5

yarn v2+ berry

yarn classic doesnt have life cycle scripts (or I dont found them 😵‍💫). So for now it only yarn 2. yarnpkg/yarn#6131

yarn add pixi-viewport@cuire/pixi-viewport#v5

pnpm

pnpm add cuire/pixi-viewport#v5

@olegarino
Copy link

olegarino commented Feb 9, 2023

This is really appreciated thank you sir.
@davidfig Would you be able to merge this ?

@voidrender
Copy link

voidrender commented Feb 12, 2023

While PR is no merged, you can use these to continue working on projects.

Installing via your fork doesn't work out of the box because the pixi-viewport code from your fork doesn't include the vite build output in the new dist directory referenced by the package.json changes (and it shouldn't).

ERROR: [plugin: vite:dep-scan] Failed to resolve entry for package "pixi-viewport". The package may have incorrect main/module/exports specified in its package.json.
Failed to resolve entry for package "pixi-viewport". The package may have incorrect main/module/exports specified in its package.json.

I was unable to build it manually inside of my app's node_modules.

Is there a good way to test this from your fork?

EDIT: Ah, it's because I'm using yarn 1.22.19, it builds with npm 8

@TimWillebrands
Copy link

I'm not sure if this PR is the cause, but when using this branch we're running into this issue with dragging: #422 (comment)

@Disorrder
Copy link

can't use this version because of events:

import { EventSystem } from "@pixi/events";

  const viewport = new Viewport({
    ticker: app.ticker,
    events: new EventSystem(app.renderer),
  });

image

@davidfig davidfig merged commit b1199bb into davidfig:master Feb 25, 2023
@davidfig
Copy link
Owner

Thanks @cuire! Published as v5 on npm.

@cuire cuire deleted the v5 branch October 16, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master lagging (npm) release
6 participants