ts client - initial prototype #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing serverSentEvents transport Updating the client 'app'
Fixing SSE transport on the server
davidfowl
reviewed
Nov 3, 2016
| @@ -21,6 +21,7 @@ public ServerSentEvents(Connection connection) | |||
| context.Response.ContentType = "text/event-stream"; | |||
| context.Response.Headers["Cache-Control"] = "no-cache"; | |||
| context.Response.Headers["Content-Encoding"] = "identity"; | |||
| await context.Response.Body.FlushAsync(); | |||
There was a problem hiding this comment.
Yes. Without that SSE does not quite work - i.e. opened event on EventSource only is sent with the first message,
moozzyk
force-pushed
the
pawelka/ts-client
branch
from
d6d9301
to
3065c8d
Compare
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the following list of TODOs:
thisin callbacks/eventhandlers