Open Telemetry Exporters #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Thanks @NielsPilgaard! |
davidfowl
reviewed
Nov 13, 2022
…lgaard/TodoApi into open-telemetry-exporters
|
So, how do we proceed from here? 😄 |
|
I think we leave in the instructions, the infra code and comment out the exporter wire up code. |
davidfowl
reviewed
Nov 18, 2022
davidfowl
reviewed
Nov 18, 2022
Prometheus too? |
That can stay since it's pull not push. |
|
Thanks @NielsPilgaard ! |
|
My pleasure, I'm glad to have contributed :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures OpenTelemetry to export spans using the OTLP Exporter.
The exported spans can be picked up by Jaeger.
Documentation for running both Jaeger and Prometheus locally have been added, and a
prometheus.ymlthat configures Prometheus to scrapedocker.host.internal:5000.Please let me know if there's anything you'd like me to do differently.
Resolves #10