New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Paste error in AsyncGuidance.md #111

Closed

gakera opened this issue Oct 31, 2023 · 1 comment

gakera commented Oct 31, 2023

Not sure what a better header text would be, but
"❌ BAD This example uses Task.Result to get the connection in the constructor. This could lead to thread-pool starvation and deadlocks." is copy pasted in this section:
https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#windowsidentityrunimpersonated

from this section:
https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#constructors

and the context doesn't make sense.

Owner

davidfowl commented Mar 20, 2024

Fixed in #114

davidfowl closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment