Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate: from __future__ import annotations, after upgrade to Python 3.13+ #183

Open
davidfstr opened this issue Jan 21, 2024 · 1 comment
Labels
priority-low Low priority items. type-feature Feature that extends the capability of Crystal in some way.

Comments

@davidfstr
Copy link
Owner

davidfstr commented Jan 21, 2024

The way of declaring annotations enabled by this future is considered deprecated, in favor of PEP 649 deferred annotations, although those annotations will only be fully available when Crystal only supports Python 3.13+

In the meantime:

  • Eliminate the __future__ import
  • Stringify annotations as needed in response
@davidfstr davidfstr added priority-low Low priority items. type-feature Feature that extends the capability of Crystal in some way. labels Jan 21, 2024
@davidfstr davidfstr self-assigned this Feb 28, 2024
@davidfstr davidfstr removed their assignment Feb 29, 2024
@davidfstr
Copy link
Owner Author

I started work on this on branch f/remove_future_annotations.

It looks like far too many annotations would need to be stringified as a response to removing from __future__ import annotations, so it may be worth cancelling this feature altogether, in favor of waiting for upgrade to Python 3.13 where PEP 649 will be available.

@davidfstr davidfstr changed the title Eliminate: from __future__ import annotations Eliminate: from __future__ import annotations, after upgrade to Python 3.13+ Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-low Low priority items. type-feature Feature that extends the capability of Crystal in some way.
Projects
None yet
Development

No branches or pull requests

1 participant