Add dbt test for address consistency
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,8 @@ | |||
| {% test is_address_lowercase(model, column_name) %} | |||
There was a problem hiding this comment.
This looks super useful for consistent merges!
DistributedDoge
force-pushed
the
testcontrib
branch
from
2e682fb
to
bab1b0a
Compare
DistributedDoge
changed the title
dbt test for address consistencydbt test for address consistency
davidgasquez
approved these changes
Jan 3, 2024
|
Ready to merge., love the new CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that make sure all addresses are stored in consistent, lowercase format.
is_address_lowercasewhich should be applied to every addressmake testwhich runsdbt testSecond commit modifies the dbt models to make sure tests actually pass.
Interesting side-effect is that calling
make run(or selectively materializing asset for which test exists) will actually run tests as the final step, even though I did not touch any configuration.