-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ covalent resource and asset #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR! Excited to have Covalent data around.
Left a few comments afteer a super quick review. Feel free to ping me once this is ready for a more formal one. 😊
New asset fetches ~3k transactions, which should cost about 300 covalent credits out of 100k monthly free tier.
Nice! Seems we can rely a lot more on Covalent.
What is needed for this PR to be ready? Happy to merge it even if not fully complete! |
The only thing needed from your side:
|
d3b2f76
to
230b8f6
Compare
If you want you can consider it ready to merge. Tested new version on the fork, and CI appears to be working, as long as COVALENT_KEY is set up first. New behaviour:
Problems:
I was hoping asset groups would be a solution, alas I don't think dagster asset selection language used by CLI and python is actually using asset groups at all.
|
CI run is actually failing. Back to the drawing board, strange that I didn't see this error maybe your covalent key wasn't pasted right?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for tidying this up!
Left a couple of mostly style suggestions.
I could not find a way to make asset optional if triggered from asset job selecting [*] like we do in make run.
This is something we could ask Dagster folks. We need (1) a way to select based on tags for this and the future incremental approach.
DESIRED behaviour would be that if we don't have a key set up, an asset doesn't even try to materialize
We can do this! Right now, the asset relies on the io manager and expect a DataFrame. We should move out of that and return a MaterializedResult we can control better.
https://github.com/davidgasquez/filecoin-data-portal/blob/main/fdp/assets.py#L16-L35
The asset code will do the same, but we add the step of materializing to DuckDB if the request
was succesful.
Does this makes sense?
I still haven't added the Covalent API key. Doing that right now! |
Co-authored-by: David Gasquez <davidgasquez@gmail.com>
Alright, |
Co-authored-by: David Gasquez <davidgasquez@gmail.com>
If you could kindly squash before merging, or however Github calls it. I don't like leaving a mess in commit history. |
Yes! In fact, let me make squashing the default in this repository. |
Forked CI with my own API key inserted will succeed now, so the most likely cause of error here is environment mismatch between our versions. Absolutely on rush to do so, but if you do happen to circle back here after the weekend:
|
Weird, there is actually a Going to merge and see if it needs to update the CI on |
Built an asset that fetches all mainnet project registry transactions. Appears to be working locally or inside reconfigured forked CI .
Manual config changes needed for new CI workflow:
COVALENT_API_KEY
set up in here.New asset fetches ~3k transactions, which should cost about 300 covalent credits out of 100k monthly free tier.
Takes about 3 minutes to run, but in parallel with other assets doesn't affect overall speed to much.