Handle ArrayValues without a values field #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgraeff
approved these changes
Sep 4, 2019
|
Could you sign your commits (use "-s" on the command line)? It's not exactly necessary for small changes, but it's a good habit. It basically means that you accept that your contributions are made available under the license of this repo. |
Signed-off-by: Daniel Bonniot <dbonniot@chemaxon.com>
dbdr
force-pushed
the
optional-values-in-array
branch
from
7eac965
to
8cd9fed
Compare
|
Signing done :) |
davidgraeff
approved these changes
Sep 4, 2019
hildaaaaa
pushed a commit
to hildachung0602/firestore-db-and-auth-rs
that referenced
this pull request
Nov 18, 2020
update query function orderby parameter using array
mkawalec
pushed a commit
to mkawalec/firestore-db-and-auth-rs
that referenced
this pull request
Jan 17, 2022
Signed-off-by: Daniel Bonniot <dbonniot@chemaxon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a documents::list, I got a deserialization failure, not on my own structures but on the
dto::ListDocumentsResponse. Turns out that inArrayValuethevaluesfield is optional. This one was confusing/fun to debug 😄