Fix jedi.api.names(..., all_scopes=False) returning class and function-level definitions #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, names defined within the scope of first-level classes or functions were returned.
immerrr
force-pushed
the
names-all-scopes-false-returns-class-fields
branch
from
64e846b
to
3f5ac0c
Compare
immerrr
changed the title
|
@davidhalter I seem to have fixed the problem described in #1202. Let me know if it looks OK. Ideally, I would change |
|
@davidhalter could you have a look at this? I would like your opinion on the previous comment. |
|
Thanks for contributing this. I'm really sorry for not keeping up with pull requests. It's been a lot of work and I was tired. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix for #1202