Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the documentation build reproducibility. #25

Merged
merged 1 commit into from Jan 9, 2018

Conversation

lamby
Copy link
Contributor

@lamby lamby commented Dec 16, 2017

Whilst working on the Reproducible Builds effort [0], we noticed
that parso could not be built reproducibly.

Patch attached that uses SOURCE_DATE_EPOCH [1].

[0] https://reproducible-builds.org/
[1] https://reproducible-builds.org/specs/source-date-epoch/

@lamby
Copy link
Contributor Author

lamby commented Dec 16, 2017

This has been filed in Debian as https://bugs.debian.org/884527

docs/conf.py Outdated
@@ -45,7 +46,8 @@

# General information about the project.
project = u'parso'
copyright = u'2012 - {today.year}, parso contributors'.format(today=datetime.date.today())
now = datetime.datetime.utcfromtimestamp(int(os.environ.get('SOURCE_DATE_EPOCH', time.time())))
copyright = u'2012 - {now.year}, parso contributors'.format(now=now)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the until-year in copyright information useless anyway?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you mean that?

@davidhalter
Copy link
Owner

How did you even find this? I'm just wondering :)

@blueyed
Copy link
Contributor

blueyed commented Dec 16, 2017

Just something I've vaguely remembered - maybe even from Ubuntu/Debian days.
Searching for "copyright year" brings up http://www.contentious.com/2007/01/07/copyright-notice-is-the-year-really-necessary/ for example.

@lamby
Copy link
Contributor Author

lamby commented Dec 17, 2017

Feel free to drop the year (which would obviously close this issue). I tend to not submit those particular requests as it's a "harder sell", prefering just to fix the existing data. :)

@davidhalter
Copy link
Owner

I agree that having this discussion is probably harder than anything else :)

But in this case I guess @blueyed is right and we can probably remove the whole copyright thing. It doesn't make any sense. The copyright exists anyway and we're not really interested in protecting the documentation. If anything we'd be interested in protecting the code. Since the code is MIT licensed we obviously don't care about that either :)

So if you could just change the PR to remove everything, thank you :)

@lamby
Copy link
Contributor Author

lamby commented Dec 17, 2017

@davidhalter Done.

@davidhalter
Copy link
Owner

Thanks man!

@davidhalter davidhalter merged commit 332c57e into davidhalter:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants