New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the documentation build reproducibility. #25
Conversation
This has been filed in Debian as https://bugs.debian.org/884527 |
docs/conf.py
Outdated
@@ -45,7 +46,8 @@ | |||
|
|||
# General information about the project. | |||
project = u'parso' | |||
copyright = u'2012 - {today.year}, parso contributors'.format(today=datetime.date.today()) | |||
now = datetime.datetime.utcfromtimestamp(int(os.environ.get('SOURCE_DATE_EPOCH', time.time()))) | |||
copyright = u'2012 - {now.year}, parso contributors'.format(now=now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the until-year in copyright information useless anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you mean that?
How did you even find this? I'm just wondering :) |
Just something I've vaguely remembered - maybe even from Ubuntu/Debian days. |
Feel free to drop the year (which would obviously close this issue). I tend to not submit those particular requests as it's a "harder sell", prefering just to fix the existing data. :) |
I agree that having this discussion is probably harder than anything else :) But in this case I guess @blueyed is right and we can probably remove the whole copyright thing. It doesn't make any sense. The copyright exists anyway and we're not really interested in protecting the documentation. If anything we'd be interested in protecting the code. Since the code is MIT licensed we obviously don't care about that either :) So if you could just change the PR to remove everything, thank you :) |
@davidhalter Done. |
Thanks man! |
Whilst working on the Reproducible Builds effort [0], we noticed
that parso could not be built reproducibly.
Patch attached that uses SOURCE_DATE_EPOCH [1].
[0] https://reproducible-builds.org/
[1] https://reproducible-builds.org/specs/source-date-epoch/