-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSDoc types and Chrome types. Fix missing awaits. Allow http feeds and sites #17
base: master
Are you sure you want to change the base?
Add JSDoc types and Chrome types. Fix missing awaits. Allow http feeds and sites #17
Conversation
@@ -151,7 +151,7 @@ <h2> | |||
> | |||
<input | |||
type="url" | |||
pattern="https://.*" | |||
pattern="https?://.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows http sites also.
@@ -7,6 +7,7 @@ | |||
"private": false, | |||
"devDependencies": { | |||
"buffer": "^6.0.3", | |||
"chrome-types": "^0.1.283", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added chrome types, so IDE like VsCode is showing types when using chrome api methods.
async function updateFeeds(config) { | ||
config.feeds.forEach(updateFeedBookmarks); | ||
for (const feed of config.feeds) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forEach is not designed to work with with async code, we should use for .. of
. More info: https://gist.github.com/joeytwiddle/37d2085425c049629b80956d3c618971
No description provided.