MBS-8819: Show action menu when loading course modules via ajax

[sh-csg]

This shows action menu when course module is rendered again after changing sth (e.g. indentation). This closes #169 .

[sh-csg]

(failing CI is not related to the patch)

[sh-csg]

Some details about the patch:

The problem arises as $PAGE->_pagetype is not set when the constructor is called for the handling of the get_fragment() call. When $PAGE->pagetype is accessed the first time (lib.php, L140), moodle_page::magic_get_pagetype() calls moodle_page::initialise_default_pagetype() where pagetype is set to "lib-ajax-service" (out of "/lib/ajax/service.php"):

moodle-format_onetopic/lib.php

Line 140 in 6c6950b

if (!in_array($PAGE->pagetype, $pagesavailable)) {

Other course formats don't access $PAGE->pagetype that early, so they get to L408 in /lib/external/externallib.php:

https://github.com/moodle/moodle/blob/d3ad77e4762ee5b96a3fecb51158c6039202f39e/lib/external/externallib.php#L408

$PAGE->set_url() sets the pagetype to "site-index" in this case.

[PhMemmel]

Can confirm this patch works, but the issue described by @sh-csg should be fixed in the course format in a cleaner way.

[izendegi]

Hi,

We've applied this patch and it fixes the issue.

[davidherney]

Hi...

Thanks @sh-csg, I've integrated the fix.

@PhMemmel If you have an idea on how to do it better, tell me and I'll review it.

Saludos