Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 7 support #71

Merged
merged 4 commits into from Mar 13, 2020
Merged

Laravel 7 support #71

merged 4 commits into from Mar 13, 2020

Conversation

palpalani
Copy link
Contributor

No description provided.

@davidhsianturi
Copy link
Owner

Hey @palpalani thanks for sending this in! Just one more thing, could you also add orchestra/testbench | ^5.0 and add Laravel 7 to the tests build? we need to make sure the tests passed for Laravel 7.

@palpalani
Copy link
Contributor Author

Hi @davidhsianturi,

Added orchestra/testbench:^5.0 and added Laravel 7 test build as well.

Note: I didn't add PHP 7.4 for test builds.

@davidhsianturi davidhsianturi merged commit 3880c91 into davidhsianturi:master Mar 13, 2020
@davidhsianturi
Copy link
Owner

@palpalani Nice, thanks!

@davidhsianturi davidhsianturi mentioned this pull request Mar 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@palpalani @davidhsianturi