Skip to content

Commit

Permalink
Properly override module in tsconfig build (#337)
Browse files Browse the repository at this point in the history
* Properly override module in tsconfig build

* Update changelog for 0.10.2

* Add deprecation warning for 0.10.0 and 0.10.1
  • Loading branch information
davidhu2000 committed Jan 2, 2021
1 parent 025bd32 commit 0d809dd
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,20 @@

All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/).

## 0.10.2

- **bugfix**: the tsconfig compiler option was not overriding properly, so the outputted files are es2015 (with import syntax) vs commonjs (with require syntax. This could cause similar issues like [#74](https://github.com/davidhu2000/react-spinners/issues/74).

## 0.10.1

**Note: this release has a critical issue and was deprecated. Please update to 0.10.2 or higher.**

- Update README using react hooks. Move react class example under a summary tag.

## 0.10.0

**Note: this release has a critical issue and was deprecated. Please update to 0.10.2 or higher.**

- update `div` to `span` to fix `<div> cannot appear as a descendant of <p>` per [#159](https://github.com/davidhu2000/react-spinners/issues/159). [PR #325](https://github.com/davidhu2000/react-spinners/pull/325)
- Using [lodash-es](https://github.com/lodash/lodash/blob/4.17.20-es/package.json#L10-L14) as a reference, added `type: module` to `package.json` as an attempt to implement tree shaking via [PR #327](https://github.com/davidhu2000/react-spinners/pull/327).
- replaced tslint with eslint, and npm with yarn.
Expand Down
3 changes: 3 additions & 0 deletions tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"module": "commonjs"
},
"exclude": ["docs/*", "webpack.config.*", "*.js", "__tests__", "examples"]
}

0 comments on commit 0d809dd

Please sign in to comment.