-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage w/o Emotion #208
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
@ioanlucut Yeah, I have same issue. I prefer a smaller bundle size. Your final bundle size now is a little huge and not fit good for production: @davidhu2000 any plan to fix this issue and decrease bundle size? |
@ioanlucut can you provide more details on your application setup? so I can create a version locally to test. If you'd like more details on why emotion was added. It was done for cleaner code and server side rendering #5 |
@davidhu2000 currently we use SCSS, so the emotion is not used at all in the codebase. Thinking out loud: maybe a solution is to use emotion but provide a dist version of the spinners with the compiled inline CSS while tree shaking everything else. |
+1 bump |
1 similar comment
+1 bump |
this seems to be the most viable solution https://stackoverflow.com/a/71102920/6496010, but it'll require a ton of rewrites. |
ok, published alpha version for one note: you'd need to add <BarLoader css={{ display: 'block' }} /> to have it show up properly. will be fixed later |
https://bundlephobia.com/package/react-spinners@0.13.0-alpha.3 https://bundlephobia.com/package/react-spinners@0.12.0 wow, removing emotion make a huge difference in size |
ok, this is published as |
going to close this real for now, please let me know if there are issues. hopefully release 0.13 by next week |
First, thanks for the lib!
However, it uses Emotion (https://github.com/davidhu2000/react-spinners/blob/master/package.json#L93) which means an extra bundle of JS for any app which does not use that framework by default.
I would love to use this without having the extra payload in our bundle.
Would this be an option?
The text was updated successfully, but these errors were encountered: