Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.11 fails - Module not found: Error: Can't resolve '@emotion/core' #425

Closed
tonydehnke opened this issue May 29, 2021 · 4 comments

Comments

@tonydehnke
Copy link

Describe the bug
(Newbie here)

When dependabot ran today - it tried to upgrade react-spinners from 0.10.6 to 0.11.0.

CI testing failed with an error: Module not found: Error: Can't resolve '@emotion/core'

I googled it and found this in another repo: projectstorm/react-diagrams#783

"Apparently in Emotion 11, @emotion/core was renamed to @emotion/react,"

It seems like maybe the dependancies for react-spinners need to be updated or changed so that the right ones are installed?

ERROR in ./app/javascript/components/EventsFormScheduler.tsx Module not found: Error: Can't resolve '@emotion/core' in '/home/circleci/project/app/javascript/components' @ ./app/javascript/components/EventsFormScheduler.tsx 20:0-36 130:9-12 @ ./app/javascript/components/EventsForm.tsx @ ./app/javascript/components/Editor.tsx @ ./app/javascript/components/Scheduler.tsx @ ./app/javascript/components/App.tsx @ ./app/javascript/packs/index.tsx

Expected Behaviour:

  • Upgrade should work, or changelog should indicate Breaking Change
@AwolDes
Copy link

AwolDes commented Jul 5, 2021

Getting a similar problem with react 17& v0.11 of spinners - #430 (comment)

@davidhu2000
Copy link
Owner

davidhu2000 commented Jul 5, 2021

hmm, that's strange, I don't see any reference to @emotion/core in this codebase. are you able to share some more code to help reproduce?

@davidhu2000
Copy link
Owner

the PR to rename to @emotion/react https://github.com/davidhu2000/react-spinners/pull/329/files

@davidhu2000
Copy link
Owner

this issue should be resolved in 0.13.0 as emotion is getting removed, see #208 and #474 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants