Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Prop Removal] add unit converter function and tests #125

Merged
merged 3 commits into from
Oct 6, 2019

Conversation

davidhu2000
Copy link
Owner

Adding a function to convert the size prop to the appropriate string.

if number => number+px
if string => validate unit, if valid, return as is, else default to px with console warning

@davidhu2000 davidhu2000 merged commit 075d0f3 into master Oct 6, 2019
@davidhu2000 davidhu2000 deleted the add-unit-converter branch October 6, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant