Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit props deprecation: update proptypes and interfaces + all loaders #138

Merged
merged 27 commits into from
Nov 24, 2019

Conversation

davidhu2000
Copy link
Owner

@davidhu2000 davidhu2000 commented Nov 12, 2019

  • deprecate sizeUnit, heightUnit, widthUnit, and radiusUnit from proptypes and interfaces. The size, height, width, radius, and margin prop all accept number or string and will add px as a default, keep the original input as is if string with valid unit, or default to px with a console warning.
  • changed css prop default to "" to fix typescript error for {} is not PrecompiledCss
  • updated all tests to include test cases for number, string w/ valid unit, string w/ invalid unit

@davidhu2000 davidhu2000 merged commit 1b4c73c into master Nov 24, 2019
@davidhu2000 davidhu2000 deleted the revert-137-revert-136-size-unit-deprecation branch November 24, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant