Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update emotion to v11 #329

Merged
merged 3 commits into from Dec 30, 2020
Merged

Update emotion to v11 #329

merged 3 commits into from Dec 30, 2020

Conversation

davidhu2000
Copy link
Owner

@davidhu2000 davidhu2000 commented Dec 30, 2020 •
edited

  • updated emotion to v11 following this guide. https://emotion.sh/docs/emotion-11
  • replaced @emotion/core with @emotion/react.
  • updated tsconfig module to es2015 to fix exports not defined error when loading the demo site here. The module config is overwritten in the build config. This should mean the outputted file does not change compared to prior versions.

The exports error is

Uncaught ReferenceError: exports is not defined

which is caused by

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });

@davidhu2000 davidhu2000 merged commit 54f9d4a into 0.11 Dec 30, 2020
@davidhu2000 davidhu2000 deleted the emotion-11 branch December 30, 2020 23:16
@Nantris
Copy link

Nantris commented Jan 26, 2021

Sounds awesome! Any ETA for release of 0.11.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidhu2000 @Nantris