Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common specs to a helper #366

Merged
merged 5 commits into from
Feb 21, 2021
Merged

Refactor common specs to a helper #366

merged 5 commits into from
Feb 21, 2021

Conversation

davidhu2000
Copy link
Owner

@davidhu2000 davidhu2000 commented Feb 21, 2021

  it("should match snapshot", () => {
  it("should contain default props if no props are passed", () => {
  it("should render null if loading prop is set as false", () => {

these 4 tests are now moved to a commonSpec file and runs for all loaders

@davidhu2000 davidhu2000 merged commit 8d96b2a into 0.11 Feb 21, 2021
@davidhu2000 davidhu2000 deleted the test-refactor branch February 21, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant