Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip ".x" version suffix #5

Merged
merged 1 commit into from
Jul 5, 2019
Merged

strip ".x" version suffix #5

merged 1 commit into from
Jul 5, 2019

Conversation

davidism
Copy link
Owner

@davidism davidism commented Jul 5, 2019

Pallets-Sphinx-Themes started reporting the docs version as "1.1.x" instead of "1.1.2.dev". That got parsed as a LegacyVersion, which sorts below other versions, so no old logs were being hidden. This change strips a ".x" suffix before parsing the version. It also omits the "Changelog" section if there are no hidden log entries.

@davidism davidism added this to the 1.0.1 milestone Jul 5, 2019
@davidism davidism merged commit 80f7701 into master Jul 5, 2019
@davidism davidism deleted the version-suffix branch July 5, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant