Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with ESBuild #1008

Closed
nandorojo opened this issue Oct 25, 2021 · 2 comments
Closed

Doesn't work with ESBuild #1008

nandorojo opened this issue Oct 25, 2021 · 2 comments
Labels

Comments

@nandorojo
Copy link

nandorojo commented Oct 25, 2021

Describe the bug

Hey, so I faced a bug where ESBuild can't properly import this library. I wrote an entire description of the issue at evanw/esbuild#1708

Thanks to the ESBuild author's help, he found that the issue was this library. It seems like a small fix, and it's all a little over my head, so I'll link to his solution here: evanw/esbuild#1708 (comment)

For now, I'm going to try the hack he mentioned.

To Reproduce

See evanw/esbuild#1708

Expected behavior

See evanw/esbuild#1708

Screenshots

See evanw/esbuild#1708

Additional context

Sorry for repetition, but it's best to see evanw/esbuild#1708

@davidjbradshaw
Copy link
Owner

I'm wondering if just getting rid of the else would fix this. Feel free to give that a go and raise a PR. I don't really have much time to dig into this right now

@davidjbradshaw
Copy link
Owner

Hopefully fixed by #1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants