Modified close to always trigger change

[ReedD]

On line 577 isSizeChangeDetected() is called and returns false which I believe is the reason the event never propagates to the parent window. I simply modified the close event to send Infinity rather than 0.

[davidjbradshaw]

That shouldn't make a difference, as the values are ignored on the host page.

[ReedD]

@davidjbradshaw the problem isn't with the host page, the problem is that the host page never even receives the event because of the function I referenced here on line 577 isSizeChangeDetected().

function isSizeChangeDetected(){
    function checkTolarance(a,b){
        var retVal = Math.abs(a-b) <= tolerance;
        return !retVal;
    }

    currentHeight = (undefined !== customHeight)  ? customHeight : getHeight[heightCalcMode]();
    currentWidth  = (undefined !== customWidth )  ? customWidth  : getWidth();

    return  checkTolarance(height,currentHeight) ||
            (calculateWidth && checkTolarance(width,currentWidth));
}

Which is defined as above. When currentHeight and customHeight are both 0 checkTolarance and thus isSizeChangeDetected both return false. If no change is detected then no event is propagated/sent to the host page. My fix sets customHeight to Infinity which essentially guarantees isSizeChangeDetected will always return true when a close event is triggered.

[davidjbradshaw]

Ah got you. Good spot.