Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loop if both JS files are added #58

Closed
porduna opened this issue Jun 4, 2014 · 12 comments
Closed

Endless loop if both JS files are added #58

porduna opened this issue Jun 4, 2014 · 12 comments
Labels

Comments

@porduna
Copy link

porduna commented Jun 4, 2014

I have three HTML files:

Each one contains the other. Both inner.html and superouter.html work as expected, but outer.html enters in an endless loop.

I see that changing msgId, it works. In a similar scenario I have:

Here, the three files work as expected. But I'd like to avoid changing the JS files in every update, if possible. Is there anything I'm missing? Is there any other way to make this scenario work?

Thank you,

@davidjbradshaw
Copy link
Owner

Do your iFrames have IDs on them?

@porduna
Copy link
Author

porduna commented Jun 4, 2014

They didn't. Now they have and I'm using iFrameResize({ ... }, "#outer") with same results.

@davidjbradshaw
Copy link
Owner

Oh the HTML tag, not the JS call.

@porduna
Copy link
Author

porduna commented Jun 4, 2014

You mean:

<iframe id="inner" src="inner.html" width="100%" ></iframe>

? Yep, I added that in the last comment and additionally used the "#inner" in the call.

@davidjbradshaw
Copy link
Owner

What happens in the endless loop? Which browser? Does the nested example work for you?

@porduna
Copy link
Author

porduna commented Jun 4, 2014

Google Chrome v35, Firefox 24 and Firefox 29 under Linux.

Sorry, hadn't seen the nested example. Same problem: it works well when opening the top frame and then clicking on the Nested link. But opening the nested frame directly, there is an endless loop where the height is being continuously increased.

@davidjbradshaw
Copy link
Owner

Oh now I understand the issue. Will take a look.

@davidjbradshaw
Copy link
Owner

@porduna
Copy link
Author

porduna commented Jun 5, 2014

Both in Firefox and Chrome it does not enter in a loop anymore. In Chrome it works perfectly, but in Firefox the iframe is not properly resized (see screenshot).

@davidjbradshaw
Copy link
Owner

Bugger seems FireFox has a function stack scoping bug in it JS implementation. Can you give it another go.

D.

@porduna
Copy link
Author

porduna commented Jun 5, 2014

Thank you! It works like a charm in Chrome, Firefox 24 and 29. Thank you!

@davidjbradshaw
Copy link
Owner

Cool will publish the fix shortly as v2.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants