Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive Event Listener for Performance #596

Merged
merged 2 commits into from
Sep 16, 2018

Conversation

thepian
Copy link

@thepian thepian commented Jun 8, 2018

Events such as touchstart and scroll must be registered in modern browsers with passive event listeners.

#595

Henrik Vendelbo(taavehe2) added 2 commits June 8, 2018 11:40
Events such as touchstart and scroll must be registered in modern browsers with passive event listeners.
@davidjbradshaw
Copy link
Owner

davidjbradshaw commented Jun 11, 2018

Thanks for this, I just came across this same issue in a project at work last week. I guess Chrome just started warning about it.

Before I merge it I just have one question, I see you check for support? Is this needed? Shouldn't old browsers just ignore this option if they don't support it?

@emilv
Copy link

emilv commented Jun 13, 2018

@davidjbradshaw You would think that, but the Chrome team decided to break backwards compatibility when they introduced this feature. The third parameter is a bool with a different meaning in previous browsers.

@davidjbradshaw davidjbradshaw merged commit 3a64654 into davidjbradshaw:master Sep 16, 2018
@davidjbradshaw
Copy link
Owner

Thank you, released v.3.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants