Fix issue 772; Use existing iframe DOM element instead of document.ge… #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So are the tests in this PR doing anything? |
|
I kept the tests in case of you was willing to trying to fix it. I'm actualy trying to test an invalid getElementById instead of trying to make shadowDom works. |
|
Ok can you take the tests out then if they are not doing anything, the change is small enough that I am happy if the current test pass with this ok |
martinbelanger
force-pushed
the
bugfix/issues/772
branch
from
392815d
to
21ab3f4
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not able to test with your automated tests.
I tried with jasmine and with qunit.
qunit in Chrome work, but shadowRoot not seems to be supported with PhantomJS.
with jasmine, even with the master code, the tests passed.