-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue package - Incorrect types for emblaApi #366
Comments
@rojadesign I think the types here should be something along these lines: export type EmblaCarouselVueType = [
Ref<HTMLElement | undefined>,
Ref<EmblaCarouselType | undefined>
] |
@davidjerleke exactly, I'm on it and will make a PR! |
…i_types Vue Package: fixed types for emblaApi. #366
Hi @rojadesign, I just released v7.0.3 that includes the fix for this type bug. Please update to the latest version and give it a go. Let me know how it goes. Thanks for reporting this. Best, |
@davidjerleke works like a charm, thank you for everything! 🤘🏼 |
@rojadesign, thanks again for reporting this problem 👍🏻. |
Bug is related to
Embla Carousel version
Describe the bug
The typings are wrong for
emblaApi
that are exposed fromembla-carousel-vue
package. The current type is:'EmblaCarouselType | HTMLElement'
Expected behavior
The type should be:
'EmblaCarouselType | null'
Additional context
Thanks @rojadesign for reporting this.
The text was updated successfully, but these errors were encountered: