Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update package.json files with correct "module" field #699

Merged
merged 1 commit into from Jan 16, 2024

Conversation

ruijdacd
Copy link
Contributor

@ruijdacd ruijdacd commented Jan 16, 2024

@davidjerleke
Copy link
Owner

@ruijdacd thanks for your contribution. Have you tested this locally and confirmed that it works?

Best,
David

@davidjerleke davidjerleke added the bug Something isn't working label Jan 16, 2024
@ruijdacd
Copy link
Contributor Author

Yes, it worked on my case! However I've actually gotten around this issue with Parcel by "making it" look for the exports field and that worked.

Here's the link just in case someone else is facing this problem: https://parceljs.org/blog/v2-9-0/#new-resolver

I'll leave that with you and I guess the community to decide wether this is something that needs to be "fixed" or not as bundlers nowadays are prioritising the exports field over main and module anyways.

@davidjerleke
Copy link
Owner

@ruijdacd even though the community is adopting exports more and more because it's more versatile, I think this PR is good because the module field should point to files that exist. Thanks for your contribution.

@davidjerleke davidjerleke self-assigned this Jan 16, 2024
Co-authored-by: David Jerleke <david.jerleke@gmail.com>
Co-authored-by: Rui Duarte <9107610+ruijdacd@users.noreply.github.com>
@davidjerleke davidjerleke merged commit 34c37e0 into davidjerleke:master Jan 16, 2024
@davidjerleke davidjerleke added the resolved This issue is resolved label Jan 16, 2024
@davidjerleke davidjerleke removed their assignment Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong path for "module" in package.json
2 participants