Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add RTL case for slide gaps via CSS in docs #786

Merged
merged 1 commit into from Apr 3, 2024

Conversation

zaaakher
Copy link
Contributor

@zaaakher zaaakher commented Mar 5, 2024

Hi @davidjerleke,

Hope you're doing well.

This PR is a simple addition to the slide-gaps section of the docs to mention the RTL case.

Let me know If I missed something

Best,
Zakher

@zaaakher zaaakher changed the title feat: add RTL case for slide gaps via CSS [Feat]: add RTL case for slide gaps via CSS Mar 5, 2024
@zaaakher zaaakher changed the title [Feat]: add RTL case for slide gaps via CSS [Feat]: add RTL case for slide gaps via CSS in docs Mar 5, 2024
@zaaakher
Copy link
Contributor Author

zaaakher commented Mar 6, 2024

Note: formatting that file via prettier kept adding an extra backtick as seen on line 50

@davidjerleke
Copy link
Owner

@zaaakher nice to have you back 🙂. Thanks for the contribution. I will review as soon as I get a chance.

Best,
David

Copy link
Owner

@davidjerleke davidjerleke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always for making this library better and easier to use 👍🏻.

Please see my minor comment and after fixing that I’m ready to merge this.

@davidjerleke davidjerleke changed the title [Feat]: add RTL case for slide gaps via CSS in docs [Feat]: Add RTL case for slide gaps via CSS in docs Mar 8, 2024
@zaaakher
Copy link
Contributor Author

zaaakher commented Mar 9, 2024

I made the changes of this PR "blindfolded" (without running the docs gatsby app due to #662). So my apologies for missing tiny things here or there 😅

@davidjerleke
Copy link
Owner

davidjerleke commented Mar 9, 2024

I made the changes of this PR "blindfolded" (without running the docs gatsby app due to #662). So my apologies for missing tiny things here or there 😅

@zaaakher no worries. I’m thankful that you continuously want to make this library better! Thanks for the fixes. I’m ready to merge this as soon as I’ve squashed the commits 🎉.

Copy link
Owner

@davidjerleke davidjerleke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ✨!

@zaaakher
Copy link
Contributor Author

zaaakher commented Mar 9, 2024

@zaaakher no worries. I’m thankful that you continuously want to make this library better! Thanks for the fixes. I’m ready to merge this as soon as I’ve squashed the commits 🎉.

You're welcome brother, it's my absolute pleasure. 🌹

@davidjerleke davidjerleke added the documentation Improvements or additions to documentation label Mar 16, 2024
Co-authored-by: David <david.jerleke@gmail.com>
@davidjerleke davidjerleke added the resolved This issue is resolved label Apr 3, 2024
@davidjerleke davidjerleke merged commit e453e61 into davidjerleke:master Apr 3, 2024
@davidjerleke
Copy link
Owner

Released in v8.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation resolved This issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants