Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Update access token scopes #40

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Update access token scopes #40

merged 1 commit into from
Jan 15, 2021

Conversation

Giaco9
Copy link
Contributor

@Giaco9 Giaco9 commented Jan 14, 2021

I'm trying to create rollbar access tokens for client side application but the creation fails because post_client_server isn't accepted as value.
Even though the rollbar REST API documentation reports post_client_server as accepted value for the scopes field, trying to call the API with that value it fails because post_client_server isn't accepted. Checking the rollbar terraform provider from Rollbar, it accepts post_client_item as value.
To be able to create access tokens for client applications, I changed all the occurrences of post_client_server with post_client_server

@Giaco9
Copy link
Contributor Author

Giaco9 commented Jan 14, 2021

I saw the required check failed, is that related to one of my changes? It seems it complains about missing environment variable. Should I change something?

@davidji99
Copy link
Owner

Hey @Giaco9,

Thanks for the PR. No worries on the test failure, a byproduct of forked repos not being able to access secrets set on the upstream repo. Let me take a look at the PR and merge if all good.

I think I might just had typed in the wrong value.

@davidji99
Copy link
Owner

Hey @Giaco9,

Just to be sure, you tried using post_client_item in a POST /api/1/project/{id}/access_tokens request to validate that it works? If so, it sounds like Rollbar needs to update their documentation.

@Giaco9
Copy link
Contributor Author

Giaco9 commented Jan 15, 2021

Yes, here are a 2 screenshots (I removed both the project id and the created access token):

failure with post_client_server
Screenshot 2021-01-15 at 13 09 24

works with post_client_item
Screenshot 2021-01-15 at 13 10 59

Yes I think the rollbar doc must be updated

@davidji99
Copy link
Owner

Gotcha. Thanks!

@davidji99 davidji99 merged commit 7e1ba8d into davidji99:master Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants