Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous cleanup #20

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Miscellaneous cleanup #20

merged 1 commit into from
Nov 23, 2022

Conversation

ajyl
Copy link
Contributor

@ajyl ajyl commented Nov 23, 2022

Lots of minor clean ups... (David, this PR is really nit-picky -- not sure if this will be the best use of your time to review...)
Also, until #19 gets merged, it won't be clear what's been changed from this PR vs. from black.

@ajyl ajyl mentioned this pull request Nov 23, 2022
@davidjurgens
Copy link
Owner

How different is this from #19 ? I think this has some of the changes from before but is mostly the same. Happy to merge this whenever it's ready to unblock #21, which is more important

@ajyl
Copy link
Contributor Author

ajyl commented Nov 23, 2022

Rebased on #19, so it should be clear now what changes have been made. It's not a ton, but it's still rather tedious to check each change. For what it's worth, I'm pretty confident I didn't break anything..... heh...

Copy link
Owner

@davidjurgens davidjurgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@davidjurgens davidjurgens merged commit 1bc6cbf into davidjurgens:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants