Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bower.json file #2

Merged
merged 1 commit into from
Apr 2, 2015
Merged

added bower.json file #2

merged 1 commit into from
Apr 2, 2015

Conversation

niepi
Copy link
Contributor

@niepi niepi commented Apr 1, 2015

Hi,

I would like to use this library with bower, so I created a bower.json file based on the package.json.

I'm not sure if there is a way to test this.

Thomas

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.47% when pulling e84afd8 on niepi:master into e4bb47d on davidkalosi:master.

davidkalosi added a commit that referenced this pull request Apr 2, 2015
added bower.json file
@davidkalosi davidkalosi merged commit 124bcd8 into davidkalosi:master Apr 2, 2015
@davidkalosi
Copy link
Owner

hi I have pushed the package into the bower registry. let me know if everything is fine.

bower info js-money
bower js-money#*            not-cached git://github.com/davidkalosi/js-money.git#*
bower js-money#*               resolve git://github.com/davidkalosi/js-money.git#*
bower js-money#*              checkout master
bower js-money#*          invalid-meta js-money is missing "ignore" entry in bower.json
bower js-money#*              resolved git://github.com/davidkalosi/js-money.git#124bcd87ff

{
  name: 'js-money',
  description: 'JavaScript implementation of the Money value object.',
  main: './lib',
  author: {
    name: 'David Kalosi',
    email: 'david.kalosi@gmail.com'
  },
  keywords: [
    'money',
    'javascript',
    'currency'
  ],
  licenses: {
    type: 'MIT'
  },
  repository: {
    type: 'git',
    url: 'git://github.com/davidkalosi/js-money.git'
  },
  bugs: {
    url: 'https://github.com/davidkalosi/js-money/issues'
  },
  dependencies: {
    lodash: '*'
  },
  devDependencies: {
    mocha: '1.x.x',
    chai: '1.x.x'
  },
  homepage: 'https://github.com/davidkalosi/js-money'
}

No versions available.

@niepi
Copy link
Contributor Author

niepi commented Apr 2, 2015

bower install worked fine, but in the bower.json I forgot the ignore entry. Can you add them?

bower documentation

ignore array: An array of paths not needed in production that you want Bower to ignore when installing your package.

{
  "name": "my-project",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<name>": "<version>",
    "<name>": "<folder>",
    "<name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

@davidkalosi
Copy link
Owner

sorry for beeing late on this - what should be the ignore array ?

@davidkalosi davidkalosi mentioned this pull request Nov 13, 2015
@davidkalosi davidkalosi mentioned this pull request Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants