This repository has been archived by the owner on Aug 23, 2022. It is now read-only.
Revert defaulting control value to a string #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the change in davidkpiano#1151. Control should not determine what type the value should be. Control needs to return the value as is.
|
Hi guys and gals, Also caused a lot of confusion on my side. Took me half a day to figure out why all of my text-masked uncontrolled inputs broke all of sudden. Should be released via npmjs repo if possible so we have a latest working version of react-redux-form. For now I'll use the package from github. Thanks for the patch! |
|
@criess I am using 1.16.8 until the next version is released. I don't know how anyone can even use 1.16.9, it completely breaks all inputs... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change in #1151. Control should not determine what type the value should be. Control needs to return the value as is.
See discussion here: ca5dda4#r29259155